Google Git
Sign in
chromium / chromium / src / 698b5ec02d193c504533fbb297299a4bc25f8b6d
commit698b5ec02d193c504533fbb297299a4bc25f8b6d[log] [tgz]
authorIan Kilpatrick <ikilpatrick@chromium.org>Fri Jun 01 17:21:14 2018
committerCommit Bot <commit-bot@chromium.org>Fri Jun 01 17:21:14 2018
treebcc052f9c562a6090c4955d34b85675ab0f25bad
parenta1dee391232d54b3f32cb7db0518bfc84b88352c [diff]
[LayoutNG] Shape fitting logic based off LineHeight.

This changes the fitting logic to be based off the LineHeight calculation,
instead of the "BlockSize" it was previously using. This makes us more
compatible with existing layout. This was making us infinite loop for a few
tests.

Additionally this fixes skipping shapes that we were previously considering in
the LineOffset computations.

Bug: 635619
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I0aaf9bb1c6972648bee8bf73d4bdb21c5b09b9ee
Reviewed-on: https://chromium-review.googlesource.com/1081351
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563697}
15 files changed
tree: bcc052f9c562a6090c4955d34b85675ab0f25bad
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. webrunner/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .