commit | 6a13c919a8a62a28cf4f3f87de0a436224c38332 | [log] [tgz] |
---|---|---|
author | manuk <manukh@chromium.org> | Fri Dec 07 15:50:23 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Dec 07 15:50:23 2018 |
tree | d7ae4d376dd7f52db93ae154c04c35422864bf85 | |
parent | cc8ef38a22bf2e10548b61aad6baba36d82f6bb9 [diff] |
[chrome:omnibox] Use Custom Elements for each sections of the output. This results in multiple organizational changes. 1) Filtering logic is engulfed by these elements instead of being grouped in FilterDelegate. FilterDelegate, as a result, only contains static methods that operate on plain strings and are oblivious to the OmniobxOutput hierarchy. 2) As FilterDelegate no longer exists, it seemed unnecessary to maintain the distinction between OmniboxOutput and RenderDelegate; RenderDelegate was merged into OmniboxOutput. 3) Decoupled display input (e.g. showDetails) logic from rendering. First, the HTML elements are created, without regards to display inputs, and then visibility of various sections is updated afterwards. This has the added advantage that toggling display inputs no longer require recreating the HTML elements. Bug: 891303 Change-Id: I7872e8b4449ce5fbd4a22e230c549ccc0d2764dd Reviewed-on: https://chromium-review.googlesource.com/c/1357010 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#614706}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .