commit 6ab180d2e31baedb52fc299660c46003e2c70d76
author Jay Civelli <jcivelli@google.com> Thu Jun 21 23:02:58 2018
committer Commit Bot <commit-bot@chromium.org> Thu Jun 21 23:02:58 2018
tree 1aeb70ac1bff6c41d94c7feac5efce7e69eefd71
parent 4d251274996d6d3289715236a8306cfd8e831ade

Converted OAuth2AccessTokenFetcher to using SimplerURLLoader.

This impacted a lot of APIs that now need to be provided with a
SharedURLLoaderFactory. Note that in many of these APIs we still need
also the net::URLRequestContextGetter as other GAIA requests still use
the networ API directly. Once all GAIA code uses the network service,
all APIs will be changed to only take the SharedURLLoaderFactory.

Many tests that simulate URL responses had to be changed and use a
TestURLLoaderFactory. In some instances, we need the
TestURLLoaderFactory for the OAuth token but still mock the URLRequests
directly for other operations.

Also:
- split up OAuth2AccessTokenFetcherImplTest.MakeGetAccessTokenBody
  into smaller tests
- exposing ways to simulate URL responses directly in
  TestURLLoaderFactory as it was required by some tests

Bug: 840396
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I6d1d1081238aa5e1d8dc5f1469e4c752c93729fc
Reviewed-on: https://chromium-review.googlesource.com/1096309
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569408}