commit | 6abfe10de3f70bcdfb5cf54fa70f300a209a5a23 | [log] [tgz] |
---|---|---|
author | Koji Ishii <kojii@chromium.org> | Thu Jul 19 01:05:39 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Jul 19 01:05:39 2018 |
tree | 3d00d01dc739f8192d832e00f5ae55e74096b026 | |
parent | 252a81307911d8855f569c59c513a3f3e54ae443 [diff] |
[LayoutNG] Fix first-line baseline when 'overflow' is not 'visible' This patch fixes first-line baseline when the 'overflow' property is other than 'visible'. CSS2 states that: The baseline of an 'inline-block' is the baseline of its last line box in the normal flow, unless it has either no in-flow line boxes or if its 'overflow' property has a computed value other than 'visible', in which case the baseline is the bottom margin edge. https://drafts.csswg.org/css2/visudet.html#propdef-vertical-align This rule should apply only to 'inline-block', but it was incorrectly applied to first-line baseline as well. This patch fixes incorrect alignment in the comment lines of Gerrit code review site. Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I49ffd8c050f384765c61c5678a431fa74492356d Reviewed-on: https://chromium-review.googlesource.com/1140336 Reviewed-by: Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#576294}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .