commit | 6c278e3a974d463bf89560ba9d3d3ebd5e1c9856 | [log] [tgz] |
---|---|---|
author | manuk <manukh@chromium.org> | Mon Dec 10 18:30:55 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Dec 10 18:30:55 2018 |
tree | 31dbb1834da23b87c62771f61be0a359cb45f5f4 | |
parent | 318899bf06319dedb69eca77fabadc6a6f578859 [diff] |
[chrome:omnibox] Join columns 'provider name' with 'type' and 'contents' with 'description'. This CL introduces support for multi-property columns. For now, we use it for the two simplest cases, but in future, more columns may display multiple columns, and some columns may display more than two properties.. Relevant minor changes also included in this CL: 1) In order to make styling multi-property cells easier, we introduce 'cell-*' CSS classes and rename the previous 'column-*' CSS classes, which referred to header cells, to 'header-*'. 2) To clarify naming, we renamed the type PresentationInfoRecord and the constant PROPERTY_OUTPUT_ORDER to Column and COLUMNS respectively. 3) To avoid post-processing the columns in order to append computed properties after first initializing them, we use a constructor instead of object literals. 4) To avoid relying on 'typeof' and reduce complexity, we declare each column's OutputProperty class (e.g. OutputBooleanProperty or OutputJsonProperty). Bug: 891303 Change-Id: I9bb15e22a9c07d42947111014213ddf3f924f9ab Reviewed-on: https://chromium-review.googlesource.com/c/1368028 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#615178}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .