Google Git
Sign in
chromium / chromium / src / 6c500722c5a1d317c823fafb6367fd50d35d0259
commit6c500722c5a1d317c823fafb6367fd50d35d0259[log] [tgz]
authorAlex Clarke <alexclarke@chromium.org>Thu Jan 10 13:22:59 2019
committerCommit Bot <commit-bot@chromium.org>Thu Jan 10 13:22:59 2019
treecd162271ff11c25f7a7f17649d0991aa13d2b4fc
parent59b327735fac25743c61745df49cb2d3caf399b9 [diff]
Fix stack splat in MessagePumpMacTest

If IncrementInModeAndExpect posted a task it didn't expect to run
within the CFRunLoopRunInMode that task would still run and splat
something on the stack. Due to luck this doesn't matter with the
MessageLoop but it causes crashes with the SequenceManager.

This patch fixes it by introducing a weak pointer in the test
task to make sure it doesn't run when it shouldn't.

Bug: 891670
Change-Id: I175903d977ee92adb2aee9461dce209dd387510a
Reviewed-on: https://chromium-review.googlesource.com/c/1403414
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621560}
5 files changed
tree: cd162271ff11c25f7a7f17649d0991aa13d2b4fc
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. cc/
  8. chrome/
  9. chrome_elf/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. jingle/
  30. mash/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. webrunner/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .