commit | 6d5075c4f0103c938c3fbdbe279c40a3efdde3b6 | [log] [tgz] |
---|---|---|
author | Bence Béky <bnc@chromium.org> | Mon May 14 10:07:52 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Mon May 14 10:07:52 2018 |
tree | 7d648b5a2db398269433d93d22cab919aa2627ed | |
parent | 7ca88b5b2405ebc3181bcb08588ff3ffd5a9e3a4 [diff] |
Do not handle impossible cases in SpdySession. Clean up some corner cases concerning HTTP/2 pushed streams. I plan to add a histogram that records every possible outcome of receiving a pushed stream, and it is cleaner if impossible cases are not handled with an early return, but they are simply documented by a DCHECK. Note that GetPromisedUrlFromHeaders() guarantees a lot of things about the pushed request: if the scheme is not http or https, or if the method is not GET or HEAD, then it returns an invalid URL. Therefore there is no need to handle these cases explicitly in SpdySession. There is test coverage in SpdyNetworkTransactionTest that enforces this. Bug: 831536 Change-Id: Ic3dae56b026598fa2965c8eee0db02cfbc95eb06 Reviewed-on: https://chromium-review.googlesource.com/1055760 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#558244}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .