Google Git
Sign in
chromium / chromium / src / 6d759e1d32ad341cd8e0d5e8666dae470b7c4aa4
commit6d759e1d32ad341cd8e0d5e8666dae470b7c4aa4[log] [tgz]
authorMounir Lamouri <mlamouri@chromium.org>Wed May 16 20:01:30 2018
committerCommit Bot <commit-bot@chromium.org>Wed May 16 20:01:30 2018
tree866b47a7df82956a5592cab42146c57d947f4d17
parent4c4bc978f240200f18a92530b9054c61fa33e05b [diff]
Picture-in-Picture: resolve exitPictureInPicture() promise when closing window.

Previously, the promise was resolved before hitting the IPC to the
browser process. This adds an ACK IPC that notifies that the operation
is done.

Technically, this isn't checking that the window is really closed but
instead the ACK is sent after `Close()` is called.

Bug: 806249
Change-Id: Ibcae8789275f743a827340d0f22485484cbac5b1
Reviewed-on: https://chromium-review.googlesource.com/1042572
Reviewed-by: Frank Liberato <liberato@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: François Beaufort <beaufort.francois@gmail.com>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559247}
22 files changed
tree: 866b47a7df82956a5592cab42146c57d947f4d17
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. webrunner/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .