Changed TextDirection to an enum class and renamed its members
Changed TextDirection to an enum class and gave it an unsigned
underlying type. Also renamed its members to use proper CamelCase
instead of all-caps.
Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)
Unlike the other enums in ComputedStyleBase, TextDirection will not be
generated. Instead, the enum from platform/ will be included and used.
This patch has no logic changes -- only renames, braces added to long
if-statements, static_casts to unsigned where the old enum type was
implicitly converted, and ASSERTs changed to DCHECKs.
BUG=628043
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Review-Url: https://codereview.chromium.org/2555923002
Cr-Commit-Position: refs/heads/master@{#440043}
84 files changed
