Google Git
Sign in
chromium / chromium / src / 6fb1f8a5425bbd6cd9e34bb78d37429d0098088b
commit6fb1f8a5425bbd6cd9e34bb78d37429d0098088b[log] [tgz]
authorThomas Tangl <tangltom@chromium.org>Mon Oct 15 14:06:54 2018
committerThomas Tangl <tangltom@chromium.org>Mon Oct 15 14:06:54 2018
tree6863b31880af57980c0996a0784d4c703d73818e
parent3df2d819383e63d4cab7ce11b9eab3eb2906f861 [diff]
Fix radio button bug on sync_page.html

The second radio button in the passphrase section
was not visibly checked on selection.

To solve this, move the spans containing the conditional
strings inside one radio-button, instead off having two
conditional radio buttons.

Additional change:
 - Remove aria-label attribute because the visible text
   is used automatically as radio button title.

Bug: 894385
Change-Id: Ie339def905ca976444880166552ba580068b9271
Reviewed-on: https://chromium-review.googlesource.com/c/1276645
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#599157}(cherry picked from commit 9b00f3499c1dc74c8e0419384a69f041ebcd2442)
Reviewed-on: https://chromium-review.googlesource.com/c/1280547
Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#20}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
1 file changed
tree: 6863b31880af57980c0996a0784d4c703d73818e
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. webrunner/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .