commit | 6fd05b6ba26a3e55cd6cc3f18f2bd909c71c3ca5 | [log] [tgz] |
---|---|---|
author | Chase Phillips <cmp@chromium.org> | Tue Feb 12 03:51:42 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Feb 12 03:51:42 2019 |
tree | 43f7bd2bbc596799014330cfe92e3047a33c6ada | |
parent | d95fa07f013a3d75267f3639101f5e0346f5bd43 [diff] |
IndexedDB: Update DispatcherHost to use WeakPtr ref to BlobStorageContext IndexedDBDispatcherHost keeps a scoped_refptr<ChromeBlobStorageContext> so that it can pass a pointer to storage::BlobStorageContext around. The pointer is used during work on the IO thread to access the BlobStorage system. Technically, there's no requirement that the blob storage system be kept alive to complete operations. Really, BlobStorage should always be running, and any situation where it isn't indicates the backing system for storage is being / has been torn down. Since that means that IndexedDBDispatcherHost doesn't actually "own" the ChromeBlobStorageContext instance, it's more accurate for this reference to be held as a WeakPtr and tested when it's needed. This change will be even more important when, in a later change, IndexedDBDispatcherHost's residence will move to the IDB task runner where it won't be possible to destroy ChromeBlobStorageContext correctly during shutdown. Bug: 717812 Change-Id: Ided90f751dc03ab0e59d8be3e4666524929336ba Reviewed-on: https://chromium-review.googlesource.com/c/1457016 Reviewed-by: Daniel Murphy <dmurph@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Commit-Queue: Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#631085}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .