commit | 707f4c1edd205d63db1c981891fe85feadfdab6d | [log] [tgz] |
---|---|---|
author | Colin Blundell <blundell@chromium.org> | Fri Nov 10 13:04:51 2017 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Nov 10 13:04:51 2017 |
tree | 39a89140ab57af0acfc4c23e8c58e6be87ef3019 | |
parent | a7dc3ad68cf2fb0c565e69d0f6ed1a82fac6a170 [diff] |
Revert "🔐 Call g_object_unref on lists returned by secret_service_search" This reverts commit a63b2ddd636c62a3fe3f5e46c6c951e9fce23993. Reason for revert: Seems to cause a unittest failure on Linux MSAN: https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.memory%2FLinux_MSan_Tests%2F5764%2F%2B%2Frecipes%2Fsteps%2Funit_tests%2F0%2Flogs%2FNativeBackendLibsecretTest.PSLMatchingDisabledForNonHTMLForms%2F0 Original change's description: > 🔐 Call g_object_unref on lists returned by secret_service_search > > We currently do not seem to be properly deleting SecretItems. > > The destruction of SecretItems is undocumented, but g_object_unref > appears to have been used in other codebases for this purpose. > > Bug: 393395 > Change-Id: I046911136bac266c0e1a42b09a8a0cb79b678f4a > Reviewed-on: https://chromium-review.googlesource.com/758851 > Reviewed-by: Vaclav Brozek <vabr@chromium.org> > Commit-Queue: Christos Froussios <cfroussios@chromium.org> > Cr-Commit-Position: refs/heads/master@{#515522} TBR=vabr@chromium.org,cfroussios@chromium.org Change-Id: I99edccd11818f72168d1bd2d7de43ccd182e83e6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 393395 Reviewed-on: https://chromium-review.googlesource.com/763311 Reviewed-by: Colin Blundell <blundell@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#515537}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .