commit | 70eba7d2d1982af6b2f14aae64f03742508b8d08 | [log] [tgz] |
---|---|---|
author | Raul Tambre <raul@tambre.ee> | Tue Jul 16 00:46:12 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Jul 16 00:46:12 2019 |
tree | 1d5ef02c1595a518b41646d23e387f254dc3f69d | |
parent | 71f0da3e9392be24fbfac48a3238ee73a9ba3349 [diff] |
setup_color: Don't fill created string buffer with nulls This causes an error since Python 3.5 due to a regression (https://bugs.python.org/issue32745): Traceback (most recent call last): File "C:\Google\depot_tools\metrics.py", line 267, in print_notice_and_exit yield File "C:\Google\depot_tools\gclient.py", line 3153, in <module> sys.exit(main(sys.argv[1:])) File "C:\Google\depot_tools\gclient.py", line 3136, in main setup_color.init() File "C:\Google\depot_tools\setup_color.py", line 70, in init buf = ctypes.create_string_buffer('\0', 1024) File "C:\Program Files\Python38\lib\ctypes\__init__.py", line 63, in create_string_buffer raise TypeError(init) TypeError: <Unicode console <stderr>>.write: ArgumentError("argument 2: <class 'ValueError'>: embedded null character") Simply not filling the buffer with NULLs doesn't change the behaviour. Bug: 942522 Change-Id: I1feb81555e995597b0b70f4aee9151fea755510c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1701402 Auto-Submit: Raul Tambre <raul@tambre.ee> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Tools for working with Chromium development. It requires python 2.7.
The most important tools are:
fetch
: A gclient
wrapper to checkout a project. Use fetch --help
for more details.gclient
: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help
for more details and README.gclient.md.git cl
: A code review tool to interact with Rietveld or Gerrit. Use git cl help
for more details and README.git-cl.md.roll-dep
: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.There are a lot of git utilities included.
depot_tools
updates itself automatically when running gclient
tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0
.
To update package manually, run update_depot_tools.bat
on Windows, or ./update_depot_tools
on Linux or Mac.
On Windows only, running gclient
will install git
and python
.
To contribute change for review:
git new-branch <somename> # Hack git add . git commit -a -m "Fixes goat teleporting" # find reviewers git cl owners git log -- <yourfiles> # Request a review. git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail # Edit change description if needed. git cl desc # If change is approved, flag it to be committed. git cl set-commit # If change needs more work. git rebase-update ... git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
Until 2018, our cpplint.py
was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py
in depot_tools
, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.
Note that the cpplint.py
here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.