commit 7b5a22c8a9dd32c540c66112f954a7413efbf97b
author Michael Spang <spang@chromium.org> Fri Nov 15 00:15:45 2019
committer Commit Bot <commit-bot@chromium.org> Fri Nov 15 00:15:45 2019
tree 6cda49df5f85b25cb9ca1ba37136eeb506371e00
parent 8f19833094694d78bd776dad51c517dd2be306c1

Reland "views: Enable toolkit_views on Chromecast builds that use views"

This reverts commit 5989e3571dbae69add528be59abafd5ac72a5574.

Reason for revert: Wrong culprit as Determinic Linux (dbg) is still red after reverting. The failure is in pak files which this shouldn't affect.

Original change's description:
> Revert "views: Enable toolkit_views on Chromecast builds that use views"
> 
> This reverts commit 57ee9cf067f3d0b321c5f34766d5e20f7308e00b.
> 
> Reason for revert: Speculative revert for the failures on deterministic builds, e.g. https://ci.chromium.org/p/chromium/builders/ci/Deterministic%20Linux%20%28dbg%29/12654
> 
> Original change's description:
> > views: Enable toolkit_views on Chromecast builds that use views
> > 
> > Chromecast uses views, but does not set toolkit_views=true. Set this to
> > true & remove desktop-oriented code that breaks in this case.
> > 
> > This replaces !defined(OS_CHROMEOS) with a new
> > BUILDFLAG(ENABLE_DESKTOP_AURA) flag as necessary throughout views.  This
> > is needed because Chromecast doesn't use desktop_aura and uses aura
> > similarly to Chrome OS by creating one WindowTreeHost for the display
> > [alternative suggestions on how to handle this distinction welcome].
> > 
> > This does not enable views in content(_shell) yet. That's left to the
> > next patch as it changes the UI.
> > 
> > As of this change, views_unittests passes in Chromecast Linux builds.
> > 
> > Bug: 1021770
> > Test: views_unittests, content_browsertests on is_chromecast=true build
> > 
> > Change-Id: I54e79402a761572feb76f122ed846558e84210b6
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907559
> > Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> > Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> > Reviewed-by: Scott Violet <sky@chromium.org>
> > Commit-Queue: Michael Spang <spang@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#715183}
> 
> TBR=sky@chromium.org,spang@chromium.org,jam@chromium.org,dpranke@chromium.org
> 
> Change-Id: I17c9efdff45b51d3a215bccd3be9eb9418478de0
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1021770
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917294
> Reviewed-by: Tommy Steimel <steimel@chromium.org>
> Commit-Queue: Tommy Steimel <steimel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#715327}

TBR=sky@chromium.org,spang@chromium.org,jam@chromium.org,dpranke@chromium.org,steimel@chromium.org

Change-Id: Ic7385336d896988c7bac9fd06f24f3cc048ba3af
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1021770
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918287
Reviewed-by: Michael Spang <spang@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715511}