Google Git
Sign in
chromium / chromium / src / 71cfe1fa662aa0b440d3aef993aa41ad1602e116
commit71cfe1fa662aa0b440d3aef993aa41ad1602e116[log] [tgz]
authorAleks Totic <atotic@chromium.org>Wed Dec 27 23:30:17 2017
committerCommit Bot <commit-bot@chromium.org>Thu Dec 28 05:19:56 2017
tree694accbf64fb1ec5d682e33606acd3965e6970bf
parent0a000da0e2e2e73eee4041e9ec1247edea576930 [diff]
[LayoutNG] Better legacy static pos computation

layout_ng_block_flow fixes static position computation. It used to be
based on ContainerBlock(), not Container() legacy funcitons expect.

ng_out_of_flow_layout_part() replaces DCHECK with NOTIMPLEMENTED. Since
only 1 remaining test fails with NOTIMPLEMENTED, I am unsure whether
implementation is necessary.

Failing test includes perspective and column width:
compositing/overflow/get-transform-from-non-box-container.html

Bug: 740993
Change-Id: Ia880b923f5fe07521498365efc46380dbb2877c2
Reviewed-on: https://chromium-review.googlesource.com/845142
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526274}
2 files changed
tree: 694accbf64fb1ec5d682e33606acd3965e6970bf
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .