commit | 6681704d5a520595a116bc5e2c770cc09630c874 | [log] [tgz] |
---|---|---|
author | Rayan Kanso <rayankans@chromium.org> | Wed Dec 04 13:40:29 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Dec 04 13:40:29 2019 |
tree | 81408116aa094d720768a261cf401919085104a5 | |
parent | 541d6521de0021524d7389596aa5078c509daefe [diff] |
Revert "Added IPH for the mini-infobar notification permission prompt (android)" This reverts commit 6e91b688d7f6225d670973c3f77146f44257c158. Reason for revert: Broke the build - https://ci.chromium.org/p/chrome/builders/ci/android-internal-chromium-tot/44960 - https://ci.chromium.org/p/chrome/builders/ci/arm64-builder-rel/20383 Original change's description: > Added IPH for the mini-infobar notification permission prompt (android) > > As part of the new quieter notification prompt, add IPH for the android > quieter notification permission prompt. To be shown the first time > the setting is enabled. > > This is controlled by using the functions: > * AdaptiveNotificationPermissionUiSelector::ShouldShowPromo > * AdaptiveNotificationPermissionUiSelector::PromoWasShown > > Quick mock of how this is supposed to look: > https://docs.google.com/document/d/1hsp1j08yzIK6M6G7pbsdEihU8CLN7QQ3V2iAxESrqQM/edit?usp=sharing > > Bug: 1029595 > Change-Id: I3c90dda846a70396f1130c2ad6dcfc3622b9b25f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944173 > Commit-Queue: Andy Paicu <andypaicu@chromium.org> > Reviewed-by: Brian White <bcwhite@chromium.org> > Reviewed-by: Matthew Jones <mdjones@chromium.org> > Reviewed-by: Kamila Hasanbega <hkamila@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Balazs Engedy <engedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#721442} TBR=nyquist@chromium.org,engedy@chromium.org,dtrainor@chromium.org,bcwhite@chromium.org,mdjones@chromium.org,bsazonov@chromium.org,andypaicu@chromium.org,hkamila@chromium.org Change-Id: Id1c9af183ed460c6e0e1159c66ec561236b13d2e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1029595 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950527 Reviewed-by: Rayan Kanso <rayankans@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#721459}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .