Google Git
Sign in
chromium / chromium / src / 2087f0a80bfba06c30bb47b7028996436288e9c7
commit2087f0a80bfba06c30bb47b7028996436288e9c7[log] [tgz]
authorAdrienne Walker <enne@chromium.org>Thu Dec 05 07:21:56 2019
committerCommit Bot <commit-bot@chromium.org>Thu Dec 05 07:21:56 2019
tree1b0478c6228aa398fc88ce1ec473891384a4d3a2
parent9fbb79b225607f1cd7d28d2c713c6d6b58cd554a [diff]
storage: Make QuotaClient refcounted

Currently, QuotaClient is a raw pointer, jointly owned by QuotaManager
and AppCacheServiceImpl, with a complicated keep_alive dance and
conditional self-destruction.

This is just a drive-by cleanup to get rid of "raw new" calls that
looked suspicious and to make the refcounting explicit.

Once AppCache gets removed, it seems possible to make QuotaClient
to be owned fully by QuotaManager as a unique_ptr.

Change-Id: I4df4bda44f51666e99880812c49ff76a7635c13d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949579
Auto-Submit: enne <enne@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721906}
44 files changed
tree: 1b0478c6228aa398fc88ce1ec473891384a4d3a2
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. ENG_REVIEW_OWNERS
  68. LICENSE
  69. LICENSE.chromium_os
  70. OWNERS
  71. PRESUBMIT.py
  72. PRESUBMIT_test.py
  73. PRESUBMIT_test_mocks.py
  74. README.md
  75. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .