Google Git
Sign in
chromium / chromium / src / 4c779c9afbb2d156352e320ee29a0f27937f8035
commit4c779c9afbb2d156352e320ee29a0f27937f8035[log] [tgz]
authorDavid Roger <droger@chromium.org>Thu Dec 05 11:11:30 2019
committerCommit Bot <commit-bot@chromium.org>Thu Dec 05 11:11:30 2019
tree0099bb96f82a2515225610e5bc2a6247dd874998
parent1cd79700fe0a67f48bdec466196da1c7c25378bb [diff]
[signin] Delete pre-dice password signin promo

This code was supposed to be dead, but actually it was still called in
wrong situations:
- on ChromeOS, I could trigger it when launching without the user
  manager.
- when disabling the "allow browser signin" setting.

In both cases, clicking on the promo triggers a DCHECK.

Fixed: 1029315
Change-Id: If213b299a847a95b292f0c1d3c44b31d12cf6037
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942657
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721969}
9 files changed
tree: 0099bb96f82a2515225610e5bc2a6247dd874998
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. ENG_REVIEW_OWNERS
  68. LICENSE
  69. LICENSE.chromium_os
  70. OWNERS
  71. PRESUBMIT.py
  72. PRESUBMIT_test.py
  73. PRESUBMIT_test_mocks.py
  74. README.md
  75. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .