commit dcc58ae0aa332072c165512113a07c4e9bf01938
author Elly Fong-Jones <ellyjones@chromium.org> Fri Dec 06 22:29:35 2019
committer Commit Bot <commit-bot@chromium.org> Fri Dec 06 22:29:35 2019
tree 130c2e914d57ced408783065c70b4280f993bc0e
parent 868344ace7e332a1be72697cca8bb6ea93148077

cbui: ExtensionInstalledBubble de-BubbleUi, part 1

Here is the overall plan of attack here:
Currently, there are three key classes:

* ExtensionInstalledBubble is a BubbleDelegate (bad)
* ExtensionInstalledBubbleUi is a BubbleUi (bad)
* ExtensionInstalledBubbleView is a BubbleDialogDelegateView (good)

The ideal end state is that all clients of ExtensionInstalledBubble
directly use ExtensionInstalledBubbleView instead, and then the former
two classes are deleted.

To get to that state, we:
1) Iteratively break every dependency from EIBV to EIB or EIBU, so that
   eventually an EIBV can be constructed without an EIB or EIBU - we do
   this by passing data from the EIB or EIBU into the EIVB's constructor
   directly so that it has it without asking the EIB.
2) Once EIBV does not depend on EIB or EIBU, make EIBV public (promote
   it into a header file), then have ShowExtensionInstalledBubble
   (the only non-test entry point to EIB) call EIBV directly
3) Delete EIB & EIBU :)

Bug: 496955
Change-Id: Ic013bf89badf507d13599ff92ebc50b6afa50f58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954739
Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722647}