Google Git
Sign in
chromium / chromium / src / 72a83a6c2276e5afcec4f87f2edad760a4809a20
commit72a83a6c2276e5afcec4f87f2edad760a4809a20[log] [tgz]
authorScott Violet <sky@chromium.org>Thu Aug 09 04:52:32 2018
committerCommit Bot <commit-bot@chromium.org>Thu Aug 09 04:52:32 2018
tree83160b99cc1606699878b038f9db3d07f1e8e06f
parent17a35d981aa27f3af2ae1be18cbe3a13bafd5d08 [diff]
views: changes test to not use equality

This test was assuming a newly created Window got a pointer value different
than one recently destroyed. For whatever reason my recent patch made it more
likely (on the msan bot) that the newly created pointer got the same value as
the one destroyed, leading to failure.

I'm converting the test to verify the window is destroyed using a WindowTracker.

BUG=847992
TEST=covered by tests

Change-Id: I4f9f64ad59ae15b0314619a93935d7e85bb6d8e7
Reviewed-on: https://chromium-review.googlesource.com/1168466
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581788}
1 file changed
tree: 83160b99cc1606699878b038f9db3d07f1e8e06f
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. webrunner/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .