commit | 72ac928f90e123b0a0fd54e3be0f6ab1fb79812d | [log] [tgz] |
---|---|---|
author | danakj <danakj@chromium.org> | Wed Dec 12 16:53:02 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Dec 12 16:53:02 2018 |
tree | 095ebe95377309f10ca9b73bacdc408ee4a6fbc6 | |
parent | 11c9531efb1a0d4cf8f28b1c34038c713fe26207 [diff] |
Reland "Remove code to store the last popup transiently in WebFrameWidgetImpl" This is a reland of 573f46751824b8dcfbec675291eacc8c581ae441 Was reverted because SitePerProcessBrowserTouchActionTest.EffectiveTouchActionPropagatesAcrossNestedFrames failed when it landed. But the test went back to green for a few runs before this was reverted, so I don't think it was at fault. We'll see if it starts failing again on reland, and I'll watch the mac bots here in the CQ. TBR=dcheng Original change's description: > Remove code to store the last popup transiently in WebFrameWidgetImpl > > This code was copied over from WebViewImpl when adding the HidePopups > call in order to have a pinch zoom or scroll tap outside the current > popup in a non-main-frame-local-rooted iframe hide the current popup. > > This is modifying state on WebViewImpl meant to track between TapDown > and Tap, to avoid the Tap showing a popup that was hidden by TapDown. > > WebFrameWidgetImpl does not show popups on Tap, and if it did, it > should track this transient state locally not on WebViewImpl. > > Also remove the undocumented FALLTHROUGH which was not explained > in 671732 as it now goes to nothing. > > R=dcheng@chromium.org > > Change-Id: I9d67539cf0afbb9db239b73bf83418e1a877e6db > Bug: 912193, 671732 > Reviewed-on: https://chromium-review.googlesource.com/c/1372539 > Reviewed-by: James MacLean <wjmaclean@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: danakj <danakj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#615708} Bug: 912193, 671732 Change-Id: I18e8e146b5b525239d1667e267d44fa8a295599d Reviewed-on: https://chromium-review.googlesource.com/c/1374193 Reviewed-by: danakj <danakj@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#615925}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .