commit | 735f19417a20a70b5f69f96f56a5a628b1256d8d | [log] [tgz] |
---|---|---|
author | George Engelbrecht <engeg@google.com> | Tue Apr 13 23:18:18 2021 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Apr 13 23:18:18 2021 |
tree | 0c8dfdb7706f69d4cefc78613235d3cfc1090387 | |
parent | ecf42915e6a642d553886dddde13e59f4fff621d [diff] |
pointless build checker: add support for relevant paths We added relevant paths to the configuration in order to make certain paths forced relevant. This change supports that and adds a test. BUG=chromium:1198619 TEST=go test Change-Id: Ie12020c49d13966309ccd1c011309d14468860d5 Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2824676 Commit-Queue: George Engelbrecht <engeg@google.com> Reviewed-by: Dhanya Ganesh <dhanyaganesh@chromium.org> Reviewed-by: Jack Neus <jackneus@google.com> Cr-Commit-Position: refs/heads/master@{#40137}
Testing Welcome to the Chrome Infra repository!
Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.
sys.path
modifications.from infra.path_hacks.common import <stg>
is actually getting <stg>
from build/scripts/common.git push origin <updated hash>:deployed
git push
commandIf you've added a new module, run your tests with test.py:
*_test.py
files to this directory.Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>
.
Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py
files in each directory of your module so Python recognizes it as a package.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores
. Use yapf (git cl format
) to autoformat new code.