commit | 73fedd040c60dbae15d97bf93926b7d577750821 | [log] [tgz] |
---|---|---|
author | Ehsan Karamad <ekaramad@chromium.org> | Tue Feb 06 21:23:01 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Feb 06 21:23:01 2018 |
tree | a848aa4efe8a66cfbbf10f47754673b3f475df0c | |
parent | 82387838336fc2d576afa160ac6b790bcb350f0e [diff] |
Fix an issue with speculative frame cleanup in OOPIFs When the beforeunload handler is ACKed by the OOPIF process with "do not proceed", the corresponding speculative frame is cleaned up. When the speculative frame is in the parent frame's process it will set the EmbeddedContentView of the owner element to nullptr. This is incorrect as the navigation has been canceled. This CL will avoid setting the EmbeddedContentView to nullptr when the ContentFrame() is not equal to Document::GetFrame() (i.e., speculative) and also the EmbeddedContentView is a RemoteFrameView. Bug: 578349, 673170, 807772 Change-Id: Ic6f5a16ae6f02bfbe11238851936ee323472a407 Reviewed-on: https://chromium-review.googlesource.com/898028 Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#534795}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .