commit | 0a900867fd82fe0a63a4cfcd91030138cf159b14 | [log] [tgz] |
---|---|---|
author | Oriol Brufau <obrufau@igalia.com> | Mon Mar 02 14:43:21 2020 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Mar 02 14:43:21 2020 |
tree | 9a01aae71841c066af8ece29dab45521fd93ff2b | |
parent | 012dc470475379ec86fd2b330cb43fb4fd6aea30 [diff] |
[css-grid] Fix referencing line both inside and after auto repeat() When referencing a line name appearing both inside and after an auto repeat(), the code used to just take the minim of: - The absolute index of the line inside the auto repeat(), i.e. the local index relative to the auto repeat() plus the insertion point of the auto repeat(). - The index of the line outside the auto repeat(), without expanding repeated tracks. This was correct if the line outside the auto repeat() preceded it. Otherwise it was wrong due to not taking repeated tracks into account. For example, with grid-template-columns: 1px repeat(auto-fill, 2px 3px [a]) [a]; the absolute index of the line inside the auto repeat() is 2 + 1 = 3. And the absolute index of the line outside the auto repeat() is 1 + 2*n. However, the used index wasn't including repeated tracks so it was 2. Therefore, the minimum was 2 but should have been 3. BUG=966090 TEST=external/wpt/css/css-grid/placement/grid-placement-using-named-grid-lines-003.html Change-Id: I1777a64d7e7d39350a327185dcd13f82493adfdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071019 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by: Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#745925}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.