commit | fb43a1a6fb29d48d4e1a5bb4b1ec8c2c50c19f27 | [log] [tgz] |
---|---|---|
author | Oriol Brufau <obrufau@igalia.com> | Fri Mar 06 13:17:39 2020 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Mar 06 13:17:39 2020 |
tree | 7b9c4803cf5b219ba7bcab6ce2acf1e4e2ee81a7 | |
parent | 3ad7e7db0be62211adb0be1a179583abeed8db0d [diff] |
[css-grid] Fix referencing implicit grid line after auto repeat() The indices of both implicit grid lines defined with grid-template-areas and explicit ones defined with grid-template-rows/columns used to be stored together in NamedGridColumnLines and NamedGridRowLines. However, this was problematic, because the former indices already refer to the final explicit grid so they don't have to be increased when expanding an auto repeat(), but the latter ones should. Therefore, this patch stores the indices in separate fields and uses the correct logic for each one. BUG=966090 TEST=external/wpt/css/css-grid/placement/grid-placement-using-named-grid-lines-005.html TEST=external/wpt/css/css-grid/placement/grid-placement-using-named-grid-lines-006.html Change-Id: I6d423148af0e4dd865f130742f7a927a325cef90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081823 Reviewed-by: Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#747669}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.