commit | 74c0d72561c3bea1cb87ba9bfe9f7e7201a1e650 | [log] [tgz] |
---|---|---|
author | Eugene But <eugenebut@google.com> | Wed Feb 21 22:53:08 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Feb 21 22:53:08 2018 |
tree | 97eb44af2309ce34e515ef923b1731730e3fd102 | |
parent | 9f2c1923a38e308d1e3f57487e3c44eb4966c149 [diff] |
Do not update Pending Item URL with URL that have a different origin. NavigationManagerImpl::UpdatePendingItemUrl exists to update the URL for redirects. UpdatePendingItemUrl is no longer used for server side redirects, so this change makes sure that pending item origin is never changed to prevent URL spoofing bugs. Conceptually this is not the right fix, because NavigationManager assumes that there can be only one pending navigation (which is not true with WKWebView). The right fix would be to switch to WK-based navigation manager, so this CL is just a workaround. Bug: 805900 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I20eed4a661244c0fec52a87b088c0620c5f57036 Reviewed-on: https://chromium-review.googlesource.com/923546 Reviewed-by: Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#538237}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .