commit | 74c92bb2207675ea7702153dd1cf60fddefe8495 | [log] [tgz] |
---|---|---|
author | benshayden <benjhayden@chromium.org> | Tue Dec 04 21:41:33 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Dec 10 22:27:37 2018 |
tree | c5f8f279c9769fc63f97ccb53862d2fba65fdf24 | |
parent | 60a61e85fed1aa7856f9dda3fe3983b6634404ad [diff] |
Add SparseDiagnostic index for _FindOrInsertDiagnosticsOutOfOrder Seeing lots of NeedIndexError in the logs for /add_histograms/process with Suite: ChromiumPerf/chromium_perf/sizes as well as others. SparseDiagnostic._FindOrInsertDiagnosticsOutOfOrder() calls query(end_revision >= rev - 1, test == test).order(-end_revision). This query requires an index like (test, -end_revision). This CL adds the required index and a debug log print. Bug: chromium:906685 Change-Id: I90ed1b6ce5e1d8fc2a620f298cb2d24d0def1ca6 Reviewed-on: https://chromium-review.googlesource.com/c/1362081 Reviewed-by: Sean McCullough <seanmccullough@chromium.org> Commit-Queue: Ben Hayden <benjhayden@chromium.org>
Catapult is the home for several performance tools that span from gathering, displaying and analyzing performance data. This includes:
These tools were created by Chromium developers for performance analysis, testing, and monitoring of Chrome, but they can also be used for analyzing and monitoring websites, and eventually Android apps.
Please see our contributor's guide