commit | c7d0001d3e1048c5ef9f28e2af23973e9468a231 | [log] [tgz] |
---|---|---|
author | Dominic Mazzoni <dmazzoni@chromium.org> | Thu Mar 19 20:43:05 2020 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Mar 19 20:43:05 2020 |
tree | 774fde976cd090393dafa01f76150f24d86f559d | |
parent | 884a90ead1a3d484c67477c3a76f54bfead8cc24 [diff] |
Fix accessibility dump tree tests to not need an end-of-file sentinel. The DumpAccessibilityTree tests generate an output text file and diff the results against an expected file. Previously, the way that the algorithm handled files of different lengths was by adding an end-of-file sentinel to the end. This resulted in that sentinel getting checked in, which was just confusing. Fix this by modifying the DiffLines helper function to properly compare files that don't have the same number of lines. Add full unit tests for DiffLines so we can be confident it works. Continue to LOG the end-of-file sentinel, because it's needed by running rebase_dump_accessibility_tree_test.py to parse actual output files from remote logs. Bug: none Change-Id: If1bcef063822fd5786acaeff9133c05d5fc5b065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109458 Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#751791}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.