Google Git
Sign in
chromium / chromium / src / 72f3015c3b8851749a6a0e0ea24d155dca15eca8
commit72f3015c3b8851749a6a0e0ea24d155dca15eca8[log] [tgz]
authorNico Weber <thakis@chromium.org>Tue Mar 24 15:45:15 2020
committerCommit Bot <commit-bot@chromium.org>Tue Mar 24 15:45:15 2020
treed249e5a677a8f3cd9cf5dac142c52861ecf56370
parent55c9c2ae93d7119e763315b7e355668fb34d373e [diff]
Reland "Enable -Wunreachable-code in Chrome OS builds."

This is a reland of 2ff5fdbc7071dbdd8bca67f3cb72cdcb636e543b with
a build fix in code that's only built on some internal bot
(it changes a FAIL() to an ADD_FAILURE() there, but the test still
passes with that). Also enable on arm builds, since the fix for
that has rolled in since the first attempt.

Original change's description:
> Enable -Wunreachable-code in (non-arm) Chrome OS builds.
>
> Bug: 1063529,346399
> Change-Id: I313ebf4cc16885d1f9bdc5a2ed8db524467735f2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116590
> Commit-Queue: Ben Pastene <bpastene@chromium.org>
> Reviewed-by: Ben Pastene <bpastene@chromium.org>
> Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> Auto-Submit: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#752618}

TBR=bpastene

Bug: 1063529, 346399
Cq-Include-Trybots: chrome/try:linux-chromeos-chrome
Change-Id: I1dd3cefcaa229b6e2655cee3cd20cf98f32be04b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116912
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#752856}
3 files changed
tree: d249e5a677a8f3cd9cf5dac142c52861ecf56370
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. ENG_REVIEW_OWNERS
  68. LICENSE
  69. LICENSE.chromium_os
  70. OWNERS
  71. PRESUBMIT.py
  72. PRESUBMIT_test.py
  73. PRESUBMIT_test_mocks.py
  74. README.md
  75. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.