Google Git
Sign in
chromium / chromium / src / 78d64d8654811ffedf085f2cd4f38ad3ee8a0dde
commit78d64d8654811ffedf085f2cd4f38ad3ee8a0dde[log] [tgz]
authorAlan Cutter <alancutter@chromium.org>Tue Mar 31 00:32:25 2020
committerCommit Bot <commit-bot@chromium.org>Tue Mar 31 00:32:25 2020
tree2a052131797011dea489e4ce9117d9040b73e4e7
parent2e3370576843b8420c90eb7f8edbcaee9770fcf2 [diff]
desktop-pwas: Treat icon processing the same for sync install as regular install

This CL removes some icon processing logic that we do differently for
sync initiated installs as they are unnecessary and contains the source
of a DCHECK failure.

We were DCHECK failing sync installation for sites that included icons
with no size specified because we were storing this as size 0. During
sync installation we would include this size 0 as part of the icons to
generate. This produced an invalid icon that failed the DCHECK in
ConvertWebAppToExtension() and caused the app sync install to fail
entirely.

Bug: 1062921
Change-Id: I273276b63ba762d522b86423cc6aaf67740a871b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120081
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754737}
6 files changed
tree: 2a052131797011dea489e4ce9117d9040b73e4e7
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. ENG_REVIEW_OWNERS
  68. LICENSE
  69. LICENSE.chromium_os
  70. OWNERS
  71. PRESUBMIT.py
  72. PRESUBMIT_test.py
  73. PRESUBMIT_test_mocks.py
  74. README.md
  75. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.