commit | 7591cbc49bf6e29303c6560d42ed53cb9423b9bb | [log] [tgz] |
---|---|---|
author | Evan Stade <estade@chromium.org> | Fri Nov 30 06:54:29 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Nov 30 06:54:29 2018 |
tree | 1bcd68a5829547a6570e279681f1d2db9f6ce898 | |
parent | 7c5eec6ffa76cf9f7f7a0af94b1a200405ca58cb [diff] |
Bring up more unit_tests for single process Mash. BrowserWithTestWindowTest now creates a MusClient, which is important for its native widget factory. AshTestViewsDelegate doesn't set the context on context/parentless widgets for Mash, since DesktopNativeWidgetAura doesn't require that and it interferes with getting the correct aura::Env. Using Shell's Env is problematic because the aura::Window for a WebContents wants to use aura::Env::GetInstance, which differs from the shell's Env. WebContentsViewAura uses the Env of its context for the aura::Window it creates, if there is a context. Also, spot fixes for: 1. LockScreenAppStateTest 2. ChromeLauncherControllerTest 3. ImmersiveModeControllerAshTest (some of these pass, a couple still fail, but none should crash) 4. TabStripTest 5. BookmarkBarViewTest Bug: 906906,905430 Change-Id: I19ce303a0cad91262c1a393379ecd5c9d2bf75fb Reviewed-on: https://chromium-review.googlesource.com/c/1351884 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#612587}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .