commit 7602f4f4603fb3f992c0deb9594f1f57e40695f8
author danakj <danakj@chromium.org> Thu Jan 31 18:03:23 2019
committer Commit Bot <commit-bot@chromium.org> Thu Jan 31 18:03:23 2019
tree bbc8cd19a7383ffee1418ffd3e24d1de540148d1
parent 66236c640db16d71a5cd3f3e59638fb323d5f542

Remove ResizingModeSelector and clarify sync resize code.

The sync resize mode, in which the renderer controls a RenderWidget's
size (always the main frame widget I am sure...) means that the
RenderWidget must ignore IPC-based control of its size from the
browser.

This mode was deprecated but later undeprecated, so we can expect it to
stay for ~forever.

In this CL we remove the ResizingModeSelector as it basically pulls
one if statement out of RenderWidget at the cost of much more difficulty
understanding the behaviour of RenderWidget, and forcing a different
public API on RenderWidget.

The ResizingModeSelector also has a method that is not used at all, so
it goes away in the process.

We add comments explaining the code's decisions and some TODOs as the
decisions look overly cautious for this limited testing scenario.

R=avi@chromium.org

Bug: 912193
Change-Id: I5def95e5e4a912f59263b6765b92ef656f62607c
Reviewed-on: https://chromium-review.googlesource.com/c/1447037
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628011}