commit 761f9fb014a66dd769a41f91c8533053110ade93
author Nigel Tao <nigeltao@chromium.org> Fri Jan 18 23:48:27 2019
committer Commit Bot <commit-bot@chromium.org> Fri Jan 18 23:48:27 2019
tree 3229bd11f738b3e136183fa8223de0eb81fe5950
parent 9ee1050885f6804b3fe5550c115b1f5df2111d6b

Load ARC++ App Service icons from the cache

Looking in the cache is what the existing code (without
--enable-features=AppService) does: e.g. ArcAppIcon::LoadForScaleFactor
calls ArcAppListPrefs::GetIconPath.

Without looking in the cache (but with --enable-features=AppService), we
have to delay calling ARC_GET_INSTANCE_FOR_METHOD(etc, RequestAppIcon)
until ARC++ is ready (as notified by arc::ConnectionObserver<etc>'s
OnConnectionReady). On my high-end test hardware, waiting for
OnConnectionReady can still take around six seconds after log-in. During
that time, prior to this commit, ARC++ apps' icons are blank.

BUG=826982

Change-Id: I9db258bf12d25a22d32c4b2b9d6756555c7256bf
Reviewed-on: https://chromium-review.googlesource.com/c/1416796
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624358}