commit | 763b79a9142f3f063eca4504dc9a45b7e75e252f | [log] [tgz] |
---|---|---|
author | Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> | Thu Dec 06 15:22:28 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Dec 06 15:22:28 2018 |
tree | b7416ada92cf0513e6c10adafc8a2d2093fa4830 | |
parent | d6f9ac554c7ac46b1401183b8925ca96327e2cf3 [diff] |
gpu_init: Stop inlining GpuInit::TakeDefaultOffscreenSurface() This fixes the GCC build after commit b6ef3ba2a3 ("Pass GpuPreferences to in-process GPU in Mash"): In file included from ../../content/utility/utility_service_factory.h:12, from ../../content/utility/utility_service_factory.cc:5: ../../base/memory/scoped_refptr.h: In instantiation of ‘static void scoped_refptr<T>::Release(T*) [with T = gl::GLSurface]’: ../../base/memory/scoped_refptr.h:208:14: required from ‘scoped_refptr<T>::~scoped_refptr() [with T = gl::GLSurface]’ ../../gpu/ipc/service/gpu_init.h:70:48: required from here ../../base/memory/scoped_refptr.h:284:8: error: invalid use of incomplete type ‘class gl::GLSurface’ ptr->Release(); ~~~~~^~~~~~~ In file included from ../../services/viz/service.h:8, from ../../content/utility/utility_service_factory.cc:35: ../../gpu/ipc/service/gpu_init.h:22:7: note: forward declaration of ‘class gl::GLSurface’ class GLSurface; ^~~~~~~~~ gpu_init.h forward-declares gl::GLSurface but using std::move() with GCC seems to require a full declaration for things to work. Bug: 819294 Change-Id: Ib22ca2f8af6977869571292acf780042507a8afd Reviewed-on: https://chromium-review.googlesource.com/c/1365249 Reviewed-by: Jonathan Backer <backer@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#614358}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .