commit 76d39b3a8d8fbd0e990f92a992d80213724de9bd
author Jinsuk Kim <jinsukkim@chromium.org> Wed Dec 05 23:06:59 2018
committer Commit Bot <commit-bot@chromium.org> Wed Dec 05 23:06:59 2018
tree c59acfa1b1fd102726d34da4d110835b12f69467
parent 3e4d0f2963c868db95bce4b4d2505f457c6d0a50

Reland "Android: Factor InProductHelp UI out of Tab"


https://chromium-review.googlesource.com/c/chromium/src/+/1272779 had a couple
of bugs in |ToolbarButtonInProductHelpController|:

1) Ignored |profile| passed into |maybeShowDownloadContinuingIPH()| and
   always used Profile.getLastUsedProfile()
2) |OnDismissListener| was instantiated (and menu got highlight for
   the text bubble) every time |setupAndMaybeShowIPHForFeature| is called,
   even when the method doesn't meet the condition for IPH text bubble
   and has to early out.

The CL got reverted due to numerous regressions . This CL fixes them and
relands it.

This reverts commit d436a7a2e33ee105a1d85370970fde3c88255302.

Bug: 889682, 907502, 907503, 907770, 907505, 907602
Change-Id: Id6de148a9fd4fd91ad7df986ca0ba78ed18e79e4
Reviewed-on: https://chromium-review.googlesource.com/c/1349142
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614161}