commit | 76f55cc9931961721237cde48796b34adf3328b8 | [log] [tgz] |
---|---|---|
author | Ben Kelly <wanderview@chromium.org> | Tue Oct 16 15:25:24 2018 |
committer | Ben Kelly <wanderview@chromium.org> | Tue Oct 16 15:25:24 2018 |
tree | 9933d2096021ba879684a562e5fc0abc0beb37a0 | |
parent | 3241a453c9e84419011563f65d41d7663579f19c [diff] |
Make DataPipeBytesConsumer support ReadableStream loading better. This CL fixes some edge condition interactions when being loaded as a ReadableStream. In particular, it: 1. Properly distinguishes between the end of the DataPipe and a closed DataPipe with bytes left to be read. A ReadableStream that is not actively draining the pipe could get closed too early. 2. Responses must support explicit completion in order to handle error conditions properly. This CL makes DataPipeBytesConsumer wait for an explicit signal before closing. 3. Service worker navigation preload is updated to provide the explicit completion signals. Bug: 894815 Change-Id: I2b5d61f9fe4a6f17c37e8a728b2f081debe6d936 Reviewed-on: https://chromium-review.googlesource.com/c/1278910 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#599739}(cherry picked from commit 2e178e0de8ca17d871fcdf56a79915bf7ebd7671) Reviewed-on: https://chromium-review.googlesource.com/c/1283412 Reviewed-by: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#38} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .