commit | a8e68b9cdef87b99ba89de9614452a709a19f757 | [log] [tgz] |
---|---|---|
author | Oriol Brufau <obrufau@igalia.com> | Tue May 26 22:13:49 2020 |
committer | Commit Bot <commit-bot@chromium.org> | Tue May 26 22:13:49 2020 |
tree | f0b3a81b52da22237882c701d9152505283bd05d | |
parent | d8f8925ac699984ee31422710d344240ac998f47 [diff] |
[css-grid] Fix 'grid-template-areas: inherit' GridTemplateAreas::ApplyInherit wasn't setting ImplicitNamedGridRowLines nor ImplicitNamedGridColumnLines inherited from the parent, so grid items referencing these lines were placed into the implicid grid. The patch also makes sure to set them in GridTemplateAreas::ApplyInitial and GridTemplateAreas::ApplyValue for a 'none' keyword. It seems these weren't causing noticeable problems, though. BUG=1085853 TEST=external/wpt/css/css-grid/placement/grid-placement-using-named-grid-lines-008.html Change-Id: If92e771d51450dea3f7fa12deaec6ce9dd7639d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214960 Reviewed-by: Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#771984}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.