commit | d96e9f16ae852ec9dbd15bf17df3d440402413bb | [log] [tgz] |
---|---|---|
author | Rune Lillesveen <futhark@chromium.org> | Sat Jun 06 18:45:29 2020 |
committer | Commit Bot <commit-bot@chromium.org> | Sat Jun 06 18:45:29 2020 |
tree | 7211d664f61d80105f5a070d96b210b47bee592c | |
parent | 8802109b07918422158a5d84f630276e00374fd8 [diff] |
Reland "Don't use @media with feature expressions in UA style." This is a reland of 9c14eacb023b53bc6363f08cf955e03e65598005 The mediaControls.css is simplified to just remove the media query since the consolidation of the two style rules in the original CL was not a no-op. Original change's description: > Don't use @media with feature expressions in UA style. > > We don't support MediaValues based feature evaluation in UA stylesheet, > only matching media types. There was an instance of > (-webkit-min-device-pixel-ratio: 2) in mediaControls.css which would > always evaluate to true in the UA sheet, but not in the context of the > evaluator in the StyleEngine for dpr=1. That caused us to constantly > update active stylesheets for frame resizes because we thought the media > result would change. > > This also contributed to hide a bug on tweetdeck.twitter.com before we > optimized the ruleset invalidation for media query changes. > > This should not be a behavior change for the mediaControls stylesheet > since the removed query would always evaluate to true so that we would > always use the high resolution image. > > Bug: 1088340 > Change-Id: I23f582893b21db6f14903836d58608caa82e5577 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228848 > Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Commit-Queue: Rune Lillesveen <futhark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#775144} TBR=steimel@chromium.org,andruud@chromium.org TEST=org.chromium.chrome.browser.vr.VrBrowserWebInputEditingTest#testFullscreenVideoControls Bug: 1088340, 1091658 Change-Id: I77df4257f291090a37ba502fcc4c42bd3b66bf21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233020 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#775897}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.