commit | d4c101ab6cd426c83de95c4c64f720c56501bbf6 | [log] [tgz] |
---|---|---|
author | Oriol Brufau <obrufau@igalia.com> | Fri Jun 12 12:28:27 2020 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Jun 12 12:28:27 2020 |
tree | 4ae9af36602d63458d7f9d20aa33ce02e7b33d2b | |
parent | 9945a86e7fe125245e691c44ad4449bc39ab2bcd [diff] |
[css-grid] Rename SmallestTrackStart to ExplicitGridStart The SmallestTrackStart method used to return a signed int which was never positive, representing the smallest untranslated start among all grid items, clamped by 0 as a maximum. In practice, though, what we usually want is the index of the first explicit track/line among all tracks/lines, or equivalently, the number of leading implicit tracks/lines. That number is precisely minus the return value of SmallestTrackStart. Thus, in grid layout there were various std::abs() to invert the value. But it's a bit confusing to have an API which returns a non-positive integer, which then needs to be made positive. Therefore, this patch renames SmallestTrackStart to ExplicitGridStart, and makes it return a positive size_t directly. This patch should have no effect in practice. TEST=GridTest.EmptyGrid TEST=GridTest.ExplicitlyPositionedChild TEST=GridTest.IntrinsicGrid TEST=GridTest.SingleChild Change-Id: Ie59a187ae29e41d5cf1030c39510aed0d6d27694 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241813 Reviewed-by: Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#777768}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.