commit | ce88cedc5a53a04d07b99fd0c1d51792ec8958de | [log] [tgz] |
---|---|---|
author | Oriol Brufau <obrufau@igalia.com> | Fri Jun 12 16:26:29 2020 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Jun 12 16:26:29 2020 |
tree | e8650c4395f498d95678b0f62c50f78984590262 | |
parent | 31d0e50559a1f4feb7fa89ba68976bf545a593be [diff] |
[css-grid] Fix line name positions after implicit tracks When serializing grid-template-rows/columns of a grid container, we get the list of used track sizes, and then insert line names at the corresponding indices. Before this patch, these indices were simply taken from the computed value. However, leading implicit tracks appear in the used value but not in the computed one. Therefore, we have to offset the indices so that the line names appear at the proper positions. BUG=790988 TEST=external/wpt/css/css-grid/parsing/grid-template-columns-computed-implicit-track.html TEST=external/wpt/css/css-grid/parsing/grid-template-rows-computed-implicit-track.html Change-Id: I778c73034c7ff9fc11a7d8a46a4042cfd1bcd1ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863092 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by: Javier Fernandez <jfernandez@igalia.com> Reviewed-by: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#777829}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.