Google Git
Sign in
chromium / chromium / src / 037d4487e3a12495bc3d32a3468da479e5361b3a
commit037d4487e3a12495bc3d32a3468da479e5361b3a[log] [tgz]
authorJinsuk Kim <jinsukkim@chromium.org>Sun Jun 14 00:26:29 2020
committerCommit Bot <commit-bot@chromium.org>Sun Jun 14 00:26:29 2020
treec076ddc7af004d7305bbcdd1bb5d259194bb41d9
parent1d22c9618faff562ba7fd92ed0115973a3db4482 [diff]
BottomSheet: Make sure to destroy the content after the base tab

Preview tab that allows for interaction with the base tab can
close the base one while the bottom sheet is in peek state.
This scenario keeps the sheet content staying hidden (suppressed),
therefore preview tab misses |BottomSheetContent.destroy|.

Repro step:

1) Open preview tab, and fully expand
2) Long press on tab switcher button
3) Close the tab

No user-visible issue here, but the current content sheet
containing the preview tab gets suppressed, and then silently
discarded by |BottomSheetControllerImpl.showNextContent|.

This CL actively destroys the currently hidden sheet content
before the next sheet is ordered to be shown.

Change-Id: Ica01d67df611468e0e4c4f48f2bc17e539cd881f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241107
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#778115}
1 file changed
tree: c076ddc7af004d7305bbcdd1bb5d259194bb41d9
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. ENG_REVIEW_OWNERS
  68. LICENSE
  69. LICENSE.chromium_os
  70. OWNERS
  71. PRESUBMIT.py
  72. PRESUBMIT_test.py
  73. PRESUBMIT_test_mocks.py
  74. README.md
  75. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.