commit | 77900be4e71e5ccda7d9efeca7bbff6dc5f3c597 | [log] [tgz] |
---|---|---|
author | Robert Iannucci <iannucci@chromium.org> | Wed Sep 19 01:33:43 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Sep 19 01:33:43 2018 |
tree | 026de0a4939e1ee021c1bd083abba29f86a5b9b0 | |
parent | 79c651330b9414a1e97450c3d22f414f9bb58a92 [diff] |
[windows_sdk] Allow taskkill mspdbsrv to fail. It looks like PNaCl actually depends on MSVC's presance, but doesn't actually run any compile steps with it (instead using clang). That means that mspdbsrv never actually runs during their build, and then the taskkill fails. R=hinoka@chromium.org, tandrii@chromium.org Bug: 861512 Change-Id: I004d28f198224adaf16b1d3f14401b0d2a7d700b Reviewed-on: https://chromium-review.googlesource.com/1232885 Reviewed-by: Ryan Tseng <hinoka@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Tools for working with Chromium development. It requires python 2.7.
The most important tools are:
fetch
: A gclient
wrapper to checkout a project. Use fetch --help
for more details.gclient
: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help
for more details and README.gclient.md.git cl
: A code review tool to interact with Rietveld or Gerrit. Use git cl help
for more details and README.git-cl.md.roll-dep
: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.There are a lot of git utilities included.
depot_tools
updates itself automatically when running gclient
tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0
.
To update package manually, run update_depot_tools.bat
on Windows, or ./update_depot_tools
on Linux or Mac.
On Windows only, running gclient
will install git
and python
.
To contribute change for review:
git new-branch <somename> # Hack git add . git commit -a -m "Fixes goat teleporting" # find reviewers git cl owners git log -- <yourfiles> # Request a review. git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail # Edit change description if needed. git cl desc # If change is approved, flag it to be committed. git cl set-commit # If change needs more work. git rebase-update ... git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
To update cpplint.py, please submit the change upstream first at https://github.com/google/styleguide/tree/gh-pages/cpplint then copy it down.