Google Git
Sign in
chromium / chromium / src / 786483cac1c90efd081159a9843e96aee5d32cbf
commit786483cac1c90efd081159a9843e96aee5d32cbf[log] [tgz]
authorScott Violet <sky@chromium.org>Fri Aug 10 20:47:29 2018
committerCommit Bot <commit-bot@chromium.org>Fri Aug 10 20:47:29 2018
tree3e951cc2928448aae8484c498ecd242e6c549bde
parent0a6088d5e92c7fd0ed853ef0767dd9b1d270c39a [diff]
ash: enforce that all Widgets have a context/parent when created

This will be important for SingleProcessMash as the context/parent is
needed to properly create the NativeWidgetDelegate. In particular
NativeWidgetAura's constructor takes an Env that comes from either the
context or parent. We need to ensure code in Ash sets that properly so that
the right Env is used.

BUG=847992
TEST=covered by tests

Change-Id: I2876ac862e00c4f03a7c328230db372f5d74a005
Reviewed-on: https://chromium-review.googlesource.com/1171204
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582322}
41 files changed
tree: 3e951cc2928448aae8484c498ecd242e6c549bde
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. webrunner/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .