commit | 78b0f0dfa9e6f3c37b71102c01def92f1ab8c330 | [log] [tgz] |
---|---|---|
author | Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> | Wed Feb 13 23:28:46 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Feb 13 23:28:46 2019 |
tree | 0c615d884362530c933db25d6c58c267491d45f3 | |
parent | af3677cd5882c92b2e5d4dd03e952367b06ea03d [diff] |
CastActivityManager: Do not make DoLaunchSessionParams' move constructor noexcept This fixes the GCC build: ../../chrome/browser/media/router/providers/cast/cast_activity_manager.cc:806:1: error: function ‘media_router::CastActivityManager::DoLaunchSessionParams::DoLaunchSessionParams(media_router::CastActivityManager::DoLaunchSessionParams&&)’ defaulted on its redeclaration with an exception-specification that differs from the implicit exception-specification ‘’ CastActivityManager::DoLaunchSessionParams::DoLaunchSessionParams( ^~~~~~~~~~~~~~~~~~~ With GCC, having that noexcept marker requires all members to be marked with noexcept themselves, and MediaRoute, CastMediaSource and url::Origin need the right annotations. Just making DoLaunchSessionParams not noexcept is the least intrusive solution for now. clang is fine because we pass -fno-exceptions and it disables the same error there, while GCC continues to raise it (bug 843143 and its corresponding CL have a longer discussion on this issue). Bug: 819294 Change-Id: Ia3a5fb60b5e74e68bd35cfa50e2fcc728b64e5eb Reviewed-on: https://chromium-review.googlesource.com/c/1469942 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#631962}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .