commit | 7901e7744e646eda0556dbeb4456c513bdab9d14 | [log] [tgz] |
---|---|---|
author | George Engelbrecht <engeg@google.com> | Wed Apr 21 18:42:51 2021 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Apr 21 18:42:51 2021 |
tree | 07c51048b93243267431b581f9e5f840fa2c0e76 | |
parent | d373a5b4dcae378b7a205d15fda28072a393262c [diff] |
cros pointless_build_checker: add ignore for known non portage We want to conditionally allow non portage paths to be ignored as is the case when checking relevancy of toolchain paths. BUG=b:186002205 TEST=go test Change-Id: If24040868ebc5a59083da4c396d6c8c82020457c Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2844138 Reviewed-by: Jack Neus <jackneus@google.com> Reviewed-by: LaMont Jones <lamontjones@chromium.org> Commit-Queue: George Engelbrecht <engeg@google.com> Cr-Commit-Position: refs/heads/master@{#40308}
Testing Welcome to the Chrome Infra repository!
Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.
sys.path
modifications.from infra.path_hacks.common import <stg>
is actually getting <stg>
from build/scripts/common.git push origin <updated hash>:deployed
git push
commandIf you've added a new module, run your tests with test.py:
*_test.py
files to this directory.Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>
.
Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py
files in each directory of your module so Python recognizes it as a package.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores
. Use yapf (git cl format
) to autoformat new code.