commit | 79573c47d98c69f3190cd8ed32cbeea46f86bcd2 | [log] [tgz] |
---|---|---|
author | Ben Pastene <bpastene@chromium.org> | Thu Apr 01 22:17:17 2021 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Apr 01 22:17:17 2021 |
tree | 1565d5c44b48f1ce1f6a91ba55d5807d98574f04 | |
parent | 8978be8d47654a318cd8776ba45c0b6a5e9dfd80 [diff] |
android_docker: Fix hostname comparison when choosing py3. This check runs in the containers, and their hostnames are of the form build1-h9--device1. So that condition was always false. Adding a wildcard should fix that. Change-Id: Ie0a7772916f45f6bf4e8c59e83fa26805f85861a Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2800567 Reviewed-by: Haiyang Pan <hypan@google.com> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#39854}
Testing Welcome to the Chrome Infra repository!
Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.
sys.path
modifications.from infra.path_hacks.common import <stg>
is actually getting <stg>
from build/scripts/common.git push origin <updated hash>:deployed
git push
commandIf you've added a new module, run your tests with test.py:
*_test.py
files to this directory.Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>
.
Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py
files in each directory of your module so Python recognizes it as a package.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores
. Use yapf (git cl format
) to autoformat new code.