commit | 7999d926809fdb560e58012dddd74b235ea1d99a | [log] [tgz] |
---|---|---|
author | Sergiy Byelozyorov <sergiyb@chromium.org> | Fri Jun 22 09:25:54 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Jun 22 09:25:54 2018 |
tree | 9619de86e094b4c08f08ebebbc8011d5d17b0d36 | |
parent | 120b2e4f2660a4c583996d5334cff1fc65c251f0 [diff] |
Revert "cpplint: Pull in upstream changes" This reverts commit f7e1e10db5f949dead75f907934aba0a4dfd8b3d. Reason for revert: breaks V8 presubmit, e.g. https://ci.chromium.org/p/v8/builders/luci.v8.try/v8_presubmit/b8943030202460843984 Original change's description: > cpplint: Pull in upstream changes > > The changes include: > - root flag now can process non-subdirectories > -- https://github.com/google/styleguide/commit/e7ddd2af622475b0c5e0f587d69fb061d2c10c46 > > - root flag can be configured with CPPLINT.cfg > -- https://github.com/google/styleguide/commit/2322e4ffaa19f4c55e5679102318ce67454fb7ed > > - root setting is relative to the CPPLINT.cfg file > -- https://github.com/google/styleguide/commit/8a87a46cc7f8d6cca5c0203ddba5d81149db7695 > > - Cleans up header file detection for hpp and hxx > > - Adds quite mode > > Bug: 852898 > > Change-Id: Id44bbfadc913cc27192049ab9a222f22d0deab5d > Reviewed-on: https://chromium-review.googlesource.com/1108381 > Commit-Queue: Amin Hassani <ahassani@chromium.org> > Reviewed-by: Aaron Gable <agable@chromium.org> TBR=agable@chromium.org,ahassani@chromium.org Change-Id: I3d380ecf8cb80000d7f7dcc0a2c75bb8a12d2a51 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 852898 Reviewed-on: https://chromium-review.googlesource.com/1111797 Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>
Tools for working with Chromium development. It requires python 2.7.
The most important tools are:
fetch
: A gclient
wrapper to checkout a project. Use fetch --help
for more details.gclient
: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help
for more details and README.gclient.md.git cl
: A code review tool to interact with Rietveld or Gerrit. Use git cl help
for more details and README.git-cl.md.roll-dep
: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.There are a lot of git utilities included.
depot_tools
updates itself automatically when running gclient
tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0
.
To update package manually, run update_depot_tools.bat
on Windows, or ./update_depot_tools
on Linux or Mac.
On Windows only, running gclient
will install git
and python
.
To contribute change for review:
git new-branch <somename> # Hack git add . git commit -a -m "Fixes goat teleporting" # find reviewers git cl owners git log -- <yourfiles> # Request a review. git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail # Edit change description if needed. git cl desc # If change is approved, flag it to be committed. git cl set-commit # If change needs more work. git rebase-update ... git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
To update cpplint.py, please submit the change upstream first at https://github.com/google/styleguide/tree/gh-pages/cpplint then copy it down.