commit | 7a09c7c9b43bcdb9d0cb1c84439e3061cab1bbbc | [log] [tgz] |
---|---|---|
author | Hiroki Nakagawa <nhiroki@chromium.org> | Fri Jan 18 10:24:34 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Jan 18 10:24:34 2019 |
tree | 3f8ad45199ef0a35280c6253ccfbe51dcba482ae | |
parent | b0afc521fa85f664f3de0d2c13a99990c4944097 [diff] |
ServiceWorker: Make FromWebServiceWorkerNetworkProvider() available for workers FromWebServiceWorkerNetworkProvider takes WebServiceWorkerNetworkProvider as an argument. Before this CL, contrary to the function name, the function implicitly assumes the given network provider is WebServiceWorkerNetworkProviderImplForFrame. This seems confusing. Actually, in the previous CL[1], I used it with WebServiceWorkerNetworkProviderImplForWorker in EmbeddedSharedWorkerStub, and it resulted in type conversion failures from ImplForWorker to ImplForFrame on static_cast. To fix it, this CL introduces WebServiceWorkerNetworkProviderBaseImpl as the base class of both ProviderImplForFrame and ProviderImplForWorker, and makes FromWebServiceWorkerNetworkProvider() take the base class as the argument. Also, this CL moves some common functions from the derived classes to the base class. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1405123 Bug: 906991, 922077 Change-Id: I7f95d41457dc5f68e15b5676fe79f2755d27176a Reviewed-on: https://chromium-review.googlesource.com/c/1420157 Reviewed-by: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#624056}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .