| commit | 7ae758248860b4dc114c8d409e34b147ab7b22fc | [log] [tgz] |
|---|---|---|
| author | Dirk Pranke <dpranke@google.com> | Wed Sep 16 22:33:42 2020 |
| committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Sep 16 22:33:42 2020 |
| tree | 09784507b1cbe4d11b9b948fbae06acbc1103f48 | |
| parent | 87ea30b322f17f58565cf012b3cdbebb09b8fd1a [diff] |
Fix swarming cmd line regression on 'Linux Tests'. Change e528d305537b61063ddbdc14106d40a829a908c2 introduced a regression where if a test-only builder contained any tests that did not use swarming, we would not pass the swarming command lines directly to the swarming tasks (and the tasks would fall back to reading them from the isolate). This CL fixes that. However, it highlights the need for us to remove the command lines from the isolates sooner rather than later to make sure there aren't other bugs hiding. Bug: 1108005 Change-Id: I22a62a7a8854dd4acb3acc6c14b15326efdcd765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2414946 Reviewed-by: Garrett Beaty <gbeaty@chromium.org> Reviewed-by: Michael Moss <mmoss@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com>
If you're here to make a change to ‘recipes’ (the code located in scripts/slave/recipes*), please take a look at the README for more information pertaining to recipes.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style. Functions use lowercase_with_underscores, with the exception of the special functions RunSteps and RunTests in recipes. Use yapf (git cl format --no-clang-format) to autoformat new code.