commit | 7b8448f77e91f2ef81e4c36929454c321895ecd7 | [log] [tgz] |
---|---|---|
author | Scott Graham <scottmg@chromium.org> | Mon Apr 10 20:24:45 2017 |
committer | Scott Graham <scottmg@chromium.org> | Mon Apr 10 20:25:14 2017 |
tree | a9a2d07d5284511e7f147cae1c3a831fc4749d72 | |
parent | d7c25fb3f81930db43ca510717d9f51006a68407 [diff] |
Revert of Allow handles through for official builds too (partial revert) (patchset #3 id:40001 of https://codereview.chromium.org/2198603002/ ) Reason for revert: Potentially causing https://crbug.com/645319. Graph to watch to see if it helps: https://goto.google.com/nezdg BUG=645319 Original issue's description: > Allow handles through for official builds too (partial revert) > > This is a (very) partial revert of > https://codereview.chromium.org/1291553003 to fix the crash reported in > https://bugs.chromium.org/p/chromium/issues/detail?id=625172#c21. I > started trying to dig into making renderers log, but it's still a hairy > mess. > > R=wfh@chromium.org > BUG=625172, 358267, 579196 > TEST=out\Release\chrome.exe http://www.bbc.co.uk/news/world-asia-china-36189636 --enable-logging=stderr > log.txt 2>&1 where chrome is is_official_build=true shouldn't crash. > > Committed: https://crrev.com/5f2967d15fe53b2bd0cec15dd22fdff3b86e1ca9 > Cr-Commit-Position: refs/heads/master@{#409318} TBR=wfh@chromium.org,sky@chromium.org,thestig@chromium.org BUG=625172, 358267, 579196 Review-Url: https://codereview.chromium.org/2767663002 Cr-Commit-Position: refs/heads/master@{#458513} (cherry picked from commit 00c0c98ea999d1d8edde6d1a2c9d3e4ff1449117) Review-Url: https://codereview.chromium.org/2810903002 . Cr-Commit-Position: refs/branch-heads/3029@{#653} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}